Skip to content

This PR is to add comments to TestGetFuseDaemonsetName in pkg\ddc\alluxio\utils_test.go.#4647

Merged
fluid-e2e-bot[bot] merged 4 commits intofluid-cloudnative:masterfrom
JefferyChu001:new-branch
Mar 20, 2025
Merged

This PR is to add comments to TestGetFuseDaemonsetName in pkg\ddc\alluxio\utils_test.go.#4647
fluid-e2e-bot[bot] merged 4 commits intofluid-cloudnative:masterfrom
JefferyChu001:new-branch

Conversation

@JefferyChu001
Copy link
Copy Markdown
Contributor

@JefferyChu001 JefferyChu001 commented Mar 12, 2025

Ⅰ. Describe what this PR does?

Add notation to TestGetFuseDaemonsetName in pkg\ddc\alluxio\utils_test.go

Ⅱ. Does this pull request fix one issue?

fixes #4645

Ⅲ. Special notes for reviews

…t.go.

Signed-off-by: JefferyChu <jefferychu@JefferyChudeMacBook-Air.local>
@fluid-e2e-bot
Copy link
Copy Markdown

fluid-e2e-bot Bot commented Mar 12, 2025

Hi @JefferyChu001. Thanks for your PR.

I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JiGuoDing
Copy link
Copy Markdown
Collaborator

JiGuoDing commented Mar 12, 2025

Hello @JefferyChu001, please leave one blank line between the comments and the above function.

Additionally, you need to clearly specify the ID of the Issue that your PR aims to fix like fixes #XXXX.

…t.go.

Signed-off-by: JefferyChu <jefferychu@JefferyChudeMacBook-Air.local>
@JiGuoDing
Copy link
Copy Markdown
Collaborator

Sorry, perhaps I didn't make myself clear. What you need to do is leave a blank line between the comments and the function preceding the one you're commenting on, rather than leaving a blank line between your comments and the function you're commenting on. Thanks.

JefferyChu added 2 commits March 14, 2025 13:13
…t.go.

Signed-off-by: JefferyChu <jefferychu@JefferyChudeMacBook-Air.local>
…t.go.

Signed-off-by: JefferyChu <jefferychu@JefferyChudeMacBook-Air.local>
@sonarqubecloud
Copy link
Copy Markdown

Copy link
Copy Markdown
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@fluid-e2e-bot
Copy link
Copy Markdown

fluid-e2e-bot Bot commented Mar 19, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fluid-e2e-bot fluid-e2e-bot Bot merged commit 0fde82b into fluid-cloudnative:master Mar 20, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add comments to TestGetFuseDaemonsetName in pkg\ddc\alluxio\utils_test.go

3 participants